Implement CloudWatch alarm SNS payloads. #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Calavera <[email protected]>
calavera
force-pushed
the
cw_alarm_sns_payload
branch
2 times, most recently
from
bf4da44 to
0328d41
Compare
|
I was too slow... thanks for the addition. |
|
no worries. I'm planning on doing a release, and I thought they could just be there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #793
Description of changes:
Add the struct definitions based on the Go events: https://github.com/aws/aws-lambda-go/blob/3a93ed1e265b5e368f0d20c3a2b8395d2c9f787d/events/sns.go#L34-L88
It doesn't look like the Java and Dotnet events implement these structs to verify them, but the tests are able to deserialize the example payloads that we've been testing already.
By submitting this pull request