Base64 encode the checksum #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjschreiber
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've figured, that the integrity checksum must be Base64 encoded, but the existing integration tests didn't show the problem due to a wrong setup. To successfully verify the
CRC64NVMEalgorithm, we need a recent LocalStack docker image.Additionally, we add CRC32 integrity check support, because it could be easier to create with existing CLI programs on a local developer machine for manual testing purposes.
While testing, we also observed debug messages with stack traces that were caused by head-object requests, where it is expected that an
NoSuchKeyExceptionoccurs. Therefore, we decided to handle this case explicitly and avoid logging (seeS3FileSystemProvider.javaline 901).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.