Feature disable tests #796
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbkok
requested changes
Mar 7, 2025
There was a problem hiding this comment.
Thank you for contributing this optimization.
I agree, for most ADF users the code is not changed outside of deploying ADF updates.
However, the default should be enabled as that is the safest approach.
Could you also update the docs/admin-guide.md to include the new config option?
Co-authored-by: Simon Kok <[email protected]>
Co-authored-by: Simon Kok <[email protected]>
sbkok
previously approved these changes
Mar 11, 2025
sbkok
reviewed
Mar 11, 2025
sbkok
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The bootstrap pipeline runs unit tests on ADF every time it is triggered. This implies the download of the development packages and the whole test suite to run, from my measurements, this adds 5-6 minutes to the overall execution time.
The current PR introduces a parameter in
adfconfig.ymlthat disables the tests. If the parameter is not present, the tests are disabled by default.What?
Description of changes:
config.run-testsinadfconfig.ymlrun-tests=enabledBy submitting this pull request, I confirm that you can use, modify, copy, and
redistribute this contribution, under the terms of your choice.