Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for AWS China regions #794

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danxie1999
Copy link

Why?

Now the we cannot deploy the AWS Deployment Framework (ADF) in AWS China regions. This pull request introduces support for the AWS China Regions in ADF.

AWS China now have two regions which are cn-north-1 and cn-northwest-1. While the cn-north-1 is the primary region, the AWS Organization events only available in cn-northwest-1.

From this perspective, additional event forwarder is required in cn-northwest-1 (aws-deployment-framework/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/china-support).

Additionally, In China region, the S3 URL is in following format: https://{self.bucket}.s3.{self.region}.{self.domain_suffix}/{key} (aws-deployment-framework/src/lambda_codebase/initial_commit/bootstrap_repository/adf-build/shared/python/s3.py ).

What?

Description of changes:

  • In the codebuild buildspec files, add pip or npm China mirrors to fix the network issue.
  • In the pytest, conformation files, change the "arn:aws" to "arn:{PARTITION}" to fix the partition issue.
  • Deploy additional resources in the cn-northwest-1 to enable the Organizations events like "move OU" and forward to the primary region "cn-north-1".
  • in the cloudformation.py, add additional parameters local_template_path and template_file_prefix to support local template path and customized template file path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant