Add Submodule Version Check to cmake Configuration #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
changed the title
sfod
reviewed
Jul 9, 2025
bretambrose
reviewed
Jul 10, 2025
xiazhvera
reviewed
Jul 10, 2025
There was a problem hiding this comment.
It seems we'd need to update the workflow to always use the script for updating submodules with the changes. I guess the goal is applied the "latest_submodules.py" across all CRT/SDKs? If that's the case we’ll need clear guidance on the new updating submodules workflow.
sfod
approved these changes
Jul 25, 2025
| " • or rerun CMake with commit checks disabled: -DENFORCE_SUBMODULE_VERSIONS=OFF") | ||
| endif() | ||
|
|
||
| function(check_submodule_commit name rel_path cmake_sym) |
There was a problem hiding this comment.
nit: cmake_sym is not used, can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check during CMake's configuration phase that determines whether the local submodules are at least the version/commit expected by aws-crt-cpp or later.
This check is done by determining the submodule commits aws-crt-cpp expects and then comparing that commit to the one that is currently actually checked out by submodules in the crt/ folder.
It will fail cmake configuration if it detects a commit that is currently in a submodule folder is older than the one expected. This check can be turned off with -DENFORCE_SUBMODULE_VERSIONS=OFF
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.