Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final request-response polish #367

Merged
merged 143 commits into from
Sep 12, 2024
Merged

Final request-response polish #367

merged 143 commits into from
Sep 12, 2024

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Apr 16, 2024

Full MQTT request-response client and subsystem implementation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 68.88889% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.04%. Comparing base (cbb958e) to head (08ef51d).

Files with missing lines Patch % Lines
source/request-response/protocol_adapter.c 0.00% 6 Missing ⚠️
source/request-response/request_response_client.c 81.25% 3 Missing ⚠️
source/request-response/subscription_manager.c 0.00% 2 Missing ⚠️
source/client_channel_handler.c 66.66% 1 Missing ⚠️
source/v5/mqtt5_client.c 91.66% 1 Missing ⚠️
source/v5/mqtt5_topic_alias.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           Elastishadow     #367   +/-   ##
=============================================
  Coverage         84.03%   84.04%           
=============================================
  Files                24       24           
  Lines             10331    10343   +12     
=============================================
+ Hits               8682     8693   +11     
- Misses             1649     1650    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bretambrose bretambrose changed the base branch from Elastishadow to main September 9, 2024 16:57
@bretambrose bretambrose changed the base branch from main to Elastishadow September 12, 2024 19:12
@bretambrose bretambrose changed the base branch from Elastishadow to main September 12, 2024 20:09
@bretambrose bretambrose merged commit 770666f into main Sep 12, 2024
32 checks passed
@bretambrose bretambrose deleted the FinalPolish branch September 12, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants