Elastishadow #366
Elastishadow #366
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## MultiSub #366 +/- ##
============================================
- Coverage 84.04% 84.03% -0.01%
============================================
Files 24 24
Lines 10335 10331 -4
============================================
- Hits 8686 8682 -4
Misses 1649 1649 ☔ View full report in Codecov by Sentry. |
|
|
||
| aws_byte_buf_clean_up(&operation->thing); | ||
| aws_byte_buf_clean_up(&operation->shadow); | ||
|
|
There was a problem hiding this comment.
May be intentional or handled elsewhere later but noting now that we're not cleaning up the topic_filter byte buf in this destroy.
There was a problem hiding this comment.
Yes, that was missed.
| AWS_BYTE_CURSOR_PRI(thing_name_cursor), | ||
| correlation_token); | ||
|
|
||
| if (aws_mqtt_request_response_client_submit_request(context->rr_client, &get_options) == AWS_OP_ERR) { |
There was a problem hiding this comment.
Trivial: We should aws_string_destroy the correlation_token here if the completion isn't going to be called.
There was a problem hiding this comment.
If applicable here, applicable in all places where we check the result of aws_mqtt_request_response_client_submit_request
| printf("Starting client!\n"); | ||
| aws_mqtt5_client_start(client); | ||
| } else if (aws_byte_cursor_eq_ignore_case(&command_cursor, &stop_cursor)) { | ||
| aws_mqtt5_client_stop(client, NULL, NULL); |
There was a problem hiding this comment.
Trivial: printf("Stopping client!\n") ?
Adds elastishadow command line test utility.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.