Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

311 listener #344

Closed
wants to merge 15 commits into from
Closed

311 listener #344

wants to merge 15 commits into from

Conversation

bretambrose
Copy link
Contributor

  • Adds listener support to 311 connections for publish received and connection success only
  • Refactors 311 protocol test fixture to be usable by multiple test .c files.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bretambrose bretambrose changed the base branch from main to ProtocolAdapterSkeleton January 26, 2024 19:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a54824a) 82.60% compared to head (67db09c) 82.78%.
Report is 2 commits behind head on ProtocolAdapterSkeleton.

Files Patch % Lines
source/mqtt311_listener.c 90.90% 10 Missing ⚠️
source/v5/mqtt5_listener.c 0.00% 1 Missing ⚠️
source/v5/mqtt5_to_mqtt3_adapter.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           ProtocolAdapterSkeleton     #344      +/-   ##
===========================================================
+ Coverage                    82.60%   82.78%   +0.17%     
===========================================================
  Files                           22       23       +1     
  Lines                         8941     9054     +113     
===========================================================
+ Hits                          7386     7495     +109     
- Misses                        1555     1559       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants