Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter subscriptions #302

Merged
merged 17 commits into from
Jul 11, 2023
Merged

Conversation

bretambrose
Copy link
Contributor

@bretambrose bretambrose commented Jun 25, 2023

Shared subscription set implementation

  • Topic tree support for mqtt 311 per-subscription publish received callbacks
  • Per-topic-filter subscription record tracking for resubscribe support
  • The subscription set could eventually replace the topic tree in the mqtt 311 implementation, but for now leave it alone

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2023

Codecov Report

Patch coverage: 97.22% and project coverage change: +0.43 🎉

Comparison is base (07bfc59) 81.11% compared to head (a09799a) 81.54%.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           AdapterOperationalState     #302      +/-   ##
===========================================================
+ Coverage                    81.11%   81.54%   +0.43%     
===========================================================
  Files                           18       19       +1     
  Lines                         7959     8134     +175     
===========================================================
+ Hits                          6456     6633     +177     
+ Misses                        1503     1501       -2     
Impacted Files Coverage Δ
source/v5/mqtt5_topic_alias.c 96.09% <ø> (-0.08%) ⬇️
source/mqtt_subscription_set.c 97.15% <97.15%> (ø)
source/client_impl_shared.c 84.61% <100.00%> (+1.28%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bretambrose bretambrose marked this pull request as ready for review June 26, 2023 20:06
@bretambrose bretambrose merged commit 9a2c01b into AdapterOperationalState Jul 11, 2023
31 checks passed
@bretambrose bretambrose deleted the AdapterSubscriptions branch July 11, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants