Adapter operational state #299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t correct to use
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 81.09% 81.11% +0.01%
==========================================
Files 18 18
Lines 7841 7958 +117
==========================================
+ Hits 6359 6455 +96
- Misses 1482 1503 +21
☔ View full report in Codecov by Sentry. |
sbSteveK
reviewed
Jun 26, 2023
sbSteveK
reviewed
Jun 26, 2023
sbSteveK
reviewed
Jun 26, 2023
sbSteveK
approved these changes
Jun 26, 2023
xiazhvera
reviewed
Jul 7, 2023
|
|
||
| /* Override timeout, rounding up as necessary */ | ||
| config->ack_timeout_seconds = aws_timestamp_convert( | ||
| connect_task->protocol_operation_timeout_ms + AWS_TIMESTAMP_MILLIS - 1, |
There was a problem hiding this comment.
I'm curious about why would we add 1 second to the operation timeout here?
|
|
||
| aws_mqtt5_operation_release(&publish_op->publish_op->base); | ||
|
|
||
| aws_mem_release(operation->allocator, operation); |
There was a problem hiding this comment.
Would we like to release publish_op instead of operation here as we allocate the publish_op in aws_mqtt3_to_mqtt5_adapter_operation_new_publish?
Meanwhile, if it was an issue, the tests should catch it. Probably I was wrong here?
xiazhvera
reviewed
Jul 7, 2023
| struct aws_mqtt_client_connection_5_impl *adapter = operation->base.adapter; | ||
|
|
||
| aws_mqtt3_to_mqtt5_adapter_operation_dereference_adapter(&operation->base); | ||
| aws_mqtt5_client_submit_operation_internal( |
There was a problem hiding this comment.
Would it make more sense to submit first then dereference the operation...?
Shared subscription set implementation * Topic tree support for mqtt 311 per-subscription publish received callbacks * Per-topic-filter subscription record tracking for resubscribe support * The subscription set could eventually replace the topic tree in the mqtt 311 implementation, but for now leave it alone --------- Co-authored-by: Bret Ambrose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.