Skip to content

Commit

Permalink
Explanation why we use new approach
Browse files Browse the repository at this point in the history
  • Loading branch information
Bret Ambrose committed Jan 19, 2024
1 parent fa655f3 commit 65229df
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions include/aws/mqtt/private/request-response/weak_ref.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@
* eventstream RPC connection. We use a single weak ref to the protocol adapter and zero its opaque value when
* the protocol adapter is destroyed. Operation callbacks that subsequently resolve can then short circuit and do
* nothing rather than call into garbage and crash.
*
* We use this rather than explicitly tracking and zeroing all pending operations (like the 3-to-5 adapter does)
* because this approach is simpler and our usage does not require any of these callbacks to be invoked once the
* request-response client is destroyed.
*/
struct aws_weak_ref;

Expand Down

0 comments on commit 65229df

Please sign in to comment.