Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omics-run-analyzer tool #29

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Add omics-run-analyzer tool #29

merged 2 commits into from
Feb 14, 2024

Conversation

ahenroid
Copy link
Contributor

Description of changes: Add omics-run-analyzer tool

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@wleepang wleepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments on CLI ergnomics, help text, and code style.

Overall, these are non-blocking issues that could be addressed later.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
omics/analyzer/omics-run-analyzer Outdated Show resolved Hide resolved
Options:
-p, --profile=<profile> AWS profile
-r, --region=<region> AWS region
-t, --time=<interval> Select runs over a time interval [default: 1day]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can help text for the -t option provide additional acceptable units? I needed to look through the code to know that this is:

m|min|minutes?|h|hours?|d|days?|w|weeks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still missing, but is minor and can be resolved in a follow-up

omics/analyzer/omics-run-analyzer Outdated Show resolved Hide resolved
omics/analyzer/omics-run-analyzer Outdated Show resolved Hide resolved
Copy link
Contributor

@wleepang wleepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional comment about CLI argument processing library

omics/analyzer/omics-run-analyzer Show resolved Hide resolved
Copy link
Contributor

@wleepang wleepang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If choosing docopt for CLI argument parsing, it needs to be added as a package dependency.

omics/analyzer/omics-run-analyzer Show resolved Hide resolved
@ahenroid
Copy link
Contributor Author

Thank you for the feedback @wleepang! I've pushed a new commit that addresses your feedback.

@wleepang wleepang merged commit 67bdb09 into main Feb 14, 2024
2 checks passed
@wleepang wleepang deleted the run-analyzer branch February 14, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants