-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add omics-run-analyzer tool #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments on CLI ergnomics, help text, and code style.
Overall, these are non-blocking issues that could be addressed later.
Options: | ||
-p, --profile=<profile> AWS profile | ||
-r, --region=<region> AWS region | ||
-t, --time=<interval> Select runs over a time interval [default: 1day] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can help text for the -t
option provide additional acceptable units? I needed to look through the code to know that this is:
m|min|minutes?|h|hours?|d|days?|w|weeks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still missing, but is minor and can be resolved in a follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One additional comment about CLI argument processing library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If choosing docopt
for CLI argument parsing, it needs to be added as a package dependency.
Thank you for the feedback @wleepang! I've pushed a new commit that addresses your feedback. |
Description of changes: Add omics-run-analyzer tool
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.