-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add AAC Support #1966
base: develop-pre-1.11.0
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1966 +/- ##
===========================================
- Coverage 88.60% 88.51% -0.09%
===========================================
Files 47 48 +1
Lines 12697 12750 +53
===========================================
+ Hits 11250 11286 +36
- Misses 1447 1464 +17 ☔ View full report in Codecov by Sentry. |
@@ -44,6 +45,7 @@ extern "C" { | |||
#define DEFAULT_PAYLOAD_MULAW (UINT64) 0 | |||
#define DEFAULT_PAYLOAD_ALAW (UINT64) 8 | |||
#define DEFAULT_PAYLOAD_OPUS (UINT64) 111 | |||
#define DEFAULT_PAYLOAD_AAC (UINT64) 96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably remove these hardcoded payload types altogether: https://issues.webrtc.org/issues/42231779
Not necessary for part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using it as a part of setPayloadTypesForOffer
actually
Issue #, if available:
What was changed?
Why was it changed?
How was it changed?
What testing was done for the changes?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.