Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvssink .so with static linkage to cproducer (#1179) #1216

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

stefankiesz
Copy link
Contributor

@stefankiesz stefankiesz commented Dec 17, 2024

Original PR:
#1179

Description of Changes

(aside from original PR changes)

  • Modified the original PR to be backwards compatible.
  • When building static libraries, kvssink will remain static as has been in the past, the new build option can force it to be shared when it is enabled.
  • Updated ReadMe to reflect these changes.
  • Added a new CMake option to the Producer C dependency in this branch to fix a can not be used when making a shared object; recompile with -fPIC build error caused by Curl not using the Position Independent Code compiler flag which prevented a static Curl build from being linked to a shared kvssink build.

Testing

  • Confirmed that building with BUILD_STATIC does create an unusable kvssink build that leads to WARNING: erroneous pipeline: no element "kvssink".
  • Tested building and running kvssink with the new changes on Ubuntu (static build does not work on Mac) - used the following build command:
cmake .. -DBUILD_STATIC=ON -DBUILD_FORCE_KVSSINK_SHARED=ON -DBUILD_GSTREAMER_PLUGIN=ON ..
  • Added a new CI test for this build configuration on Linux.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@stefankiesz stefankiesz changed the title kvssink .so with static linkage to cproducer [#1179](https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/pull/1179) kvssink .so with static linkage to cproducer (#1179) Dec 17, 2024
@stefankiesz stefankiesz marked this pull request as ready for review December 17, 2024 22:38
@stefankiesz stefankiesz added build Changes to CMakeLists.txt gstreamer Changes to kvssink or the kvssink samples labels Dec 18, 2024
@stefankiesz
Copy link
Contributor Author

ToDO: Change the Producer C dependency version to develop once the corresponding PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes to CMakeLists.txt gstreamer Changes to kvssink or the kvssink samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants