kvssink .so with static linkage to cproducer (#1179) #1216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
#1179
Description of Changes
(aside from original PR changes)
kvssink
will remain static as has been in the past, the new build option can force it to be shared when it is enabled.can not be used when making a shared object; recompile with -fPIC
build error caused by Curl not using the Position Independent Code compiler flag which prevented a static Curl build from being linked to a sharedkvssink
build.Testing
BUILD_STATIC
does create an unusablekvssink
build that leads toWARNING: erroneous pipeline: no element "kvssink"
.kvssink
with the new changes on Ubuntu (static build does not work on Mac) - used the following build command:By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.