Fragment aggregation #123
Draft
Fragment aggregation #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o OOM in the encapsulated heap
hassanctech
reviewed
Mar 18, 2021
| for (i = 0, pCurPtr = pBuffer + offset; i < size; i++, pCurPtr++) { | ||
| CHK(EOF != FPUTC(*pCurPtr, fp), STATUS_WRITE_TO_FILE_FAILED); | ||
| for (i = 0; i < size; i++, pBuffer++) { | ||
| CHK(EOF != FPUTC(*pBuffer, fp), STATUS_WRITE_TO_FILE_FAILED); |
There was a problem hiding this comment.
This is not the same as before right? Before we start writing at (pBuffer + offset), now we start writing at pBuffer.
Looks like it should be a while loop anyway but if we keep the for loop let's set the range of i to be from offset to offset + size and then in the FPUTC we can add i to pBuffer.
A number of ways to do it, but this change is different than what was there before.
MushMal
commented
Mar 18, 2021
| @@ -795,6 +810,14 @@ STATUS putFrame(PKinesisVideoStream pKinesisVideoStream, PFrame pFrame) | |||
| if (pKinesisVideoStream->resetGeneratorOnKeyFrame && CHECK_FRAME_FLAG_KEY_FRAME(pFrame->flags)) { | |||
| CHK_STATUS(mkvgenResetGenerator(pKinesisVideoStream->pMkvGenerator)); | |||
| pKinesisVideoStream->resetGeneratorOnKeyFrame = FALSE; | |||
|
|
|||
There was a problem hiding this comment.
Might want to add client locking/unlocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.