Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add palantir-java-format via spotless. #1332

Merged
merged 4 commits into from
May 21, 2024
Merged

Add palantir-java-format via spotless. #1332

merged 4 commits into from
May 21, 2024

Conversation

nakulj
Copy link
Contributor

@nakulj nakulj commented May 20, 2024

Description of changes:

Enforce consistent code style with palantir-java-format.
Allows automatic formatting via mvn spotless:apply.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@brendan-p-lynch brendan-p-lynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was primarily done for code consistency. I don't see any problems inherent to it.

@nakulj nakulj merged commit adcc89f into awslabs:master May 21, 2024
0 of 2 checks passed
@nakulj nakulj deleted the fmt branch May 21, 2024 08:27
nakulj added a commit to nakulj/amazon-kinesis-client that referenced this pull request May 21, 2024
Follow up to awslabs#1332.
- Manually split up a long string literal.
- Disable ArrayTrailingComma, which checkstyle complains about even in
  commented code. In any case it is redundant with PJF.
nakulj added a commit that referenced this pull request May 21, 2024
Follow up to #1332.
- Manually split up a long string literal.
- Disable ArrayTrailingComma, which checkstyle complains about even in
  commented code. In any case it is redundant with PJF.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants