Modify backwards compatibility script to ignore synthetic access methods #1330
Conversation
| @@ -82,6 +82,9 @@ find_removed_methods() { | |||
|
|
|||
| local removed_methods=$(diff <(echo "$LATEST_METHODS") <(echo "$CURRENT_METHODS") | grep '^<') | |||
|
|
|||
| # ignore synthetic access methods - these are not available to users and will not break backwards compatibility | |||
| removed_methods=$(echo "$removed_methods" | grep -v "access\$[1-4]00") | |||
There was a problem hiding this comment.
IS there a reason we set this and then immdediately change it again. Could we do this in one line?
Also if you can provide why that grep works well that would be great. I don't have an intuition for this line: grep -v "access$[1-4]00"
There was a problem hiding this comment.
Main reason as to why it's on its own line is just to make it explicit that we are ignoring these types of errors. We can include it in the same line but imo I think it's better to keep it separate and make it clear we're ignoring synthetic methods with the following line.
What grep -v <...> does is filter out any lines that contain the specified pattern. If we find that access$100, access$200, access$300, or access$400 is in the original diff output, we remove the line from the output (i.e. we ignore any changes related to access$[1-4]00).
FYI the newest commit changes this to ignore access$000 to access$900.
There was a problem hiding this comment.
Ok, it's not super intuitive to me but if it is standard and doesn't need a comment that is ok
Issue #, if available: N/A
Description of changes: Modify backwards compatibility script to ignore synthetic access methods. These access methods are not public and should not affect backwards compatibility.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.