Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpirun protocol - distributed training with @remote decorator #4998

Merged
merged 21 commits into from
Jan 31, 2025

Conversation

brunopistone
Copy link
Collaborator

@brunopistone brunopistone commented Jan 21, 2025

Issue #, if available:

Description of changes: Introduced mpirun protocol for distributed training with multiple instances (instance_count > 1) with with remote decorator. mpirun protocol is the alternative to the torchrun protocol, introduced with PR merged #4984

Testing done: Unit tests mpirun single node with GPU, single node with multiple GPUs, multi node with multiple GPUs. Added new test cases for mpi_tuils_remote.py

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ x ] I have read the CONTRIBUTING doc
  • [ x ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [ x ] I used the commit message format described in CONTRIBUTING
  • [ x ] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ x ] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [ x ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [ x ] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [ x ] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [ x ] I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • [ x ] If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brunopistone brunopistone requested a review from a team as a code owner January 21, 2025 12:28
@brunopistone brunopistone requested a review from benieric January 21, 2025 12:28
nargokul
nargokul previously approved these changes Jan 21, 2025
benieric
benieric previously approved these changes Jan 30, 2025
@benieric
Copy link
Contributor

Is there any related documentation for remote decorator that should be updated for this change? under https://github.com/aws/sagemaker-python-sdk/tree/master/doc

@benieric benieric self-requested a review January 30, 2025 02:37
@benieric benieric dismissed their stale review January 30, 2025 02:37

had a question

@brunopistone
Copy link
Collaborator Author

Is there any related documentation for remote decorator that should be updated for this change? under master/doc

Classes are properly commented for having the documentation aligned with changes. This is the reference documentation (See use_torchrun parameter)

@benieric benieric merged commit 6d2dfa0 into aws:master Jan 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants