Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix artifact not being cleaned up #194

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix artifact not being cleaned up #194

wants to merge 1 commit into from

Conversation

rd-pong
Copy link
Member

@rd-pong rd-pong commented Nov 14, 2023

Issue #, if available:

  • Artifacts are not cleaned up after testing. And we are getting errors:
botocore.errorfactory.ResourceLimitExceeded: An error occurred (ResourceLimitExceeded) when calling the CreateArtifact operation: The account-level service limit 'Total number of artifacts allowed, excluding those automatically created by SageMaker' is 6000 Artifacts, with current utilization of 6000 Artifacts and a request delta of 1 Artifacts.

Description of changes:

  • Added clean up logic after running log_artifact.

Testing done:
integ test

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rd-pong rd-pong requested a review from a team as a code owner November 14, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant