chore(bindings): change in rustup behavior #5160
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
approved these changes
Mar 4, 2025
| @@ -35,6 +35,9 @@ cp -r \ | |||
|
|
|||
| # generate the bindings modules from the copied sources | |||
| pushd generate | |||
| # Behavior change from https://github.com/rust-lang/rustup/pull/3985 | |||
| rustc --version || rustup toolchain install | |||
There was a problem hiding this comment.
On one hand it feels weird to install the toolchain in the script, but I guess that was the previous behavior?
Approving because we only expect this to be run by s2n-tls developers, so it should be a totally internal change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
none
Description of changes:
Our rust related GitHub actions are failing on the
generate.shstep with:Which appears related to rust-lang/rustup#3985
Adds a test to see if the toolchain is available and if not, install it.
Call-outs
This seems like it should belong in a rust setup related action instead?
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.