fix(bindings): Specify correct minimum versions #5028
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -366,3 +366,45 @@ jobs: | |
| - name: Run tests | ||
| working-directory: ${{env.PCAP_TEST_PATH}} | ||
| run: cargo test --all-features | ||
|
|
||
| minimal-versions: | ||
| runs-on: ubuntu-24.04 | ||
| strategy: | ||
| matrix: | ||
| workspace-path: | ||
| - bindings/rust/extended | ||
| - bindings/rust/standard | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Install Rust toolchain | ||
| id: toolchain | ||
| # minimal-versions is an unstable feature, and requires the nightly toolchain: | ||
| # https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#minimal-versions | ||
| run: | | ||
| rustup toolchain install ${{env.RUST_NIGHTLY_TOOLCHAIN}} | ||
| rustup override set ${{env.RUST_NIGHTLY_TOOLCHAIN}} | ||
|
|
||
| - uses: camshaft/rust-cache@v1 | ||
|
|
||
| # cargo-minimal-versions requires cargo-hack: | ||
| # https://crates.io/crates/cargo-minimal-versions#user-content-prerequisites | ||
| - name: Install cargo-hack | ||
| uses: baptiste0928/[email protected] | ||
| with: | ||
| crate: cargo-hack | ||
|
|
||
| - name: Install cargo-minimal-versions | ||
| uses: baptiste0928/[email protected] | ||
| with: | ||
| crate: cargo-minimal-versions | ||
|
|
||
| - name: Generate | ||
| run: ./${{env.ROOT_PATH}}/generate.sh --skip-tests | ||
|
|
||
| - name: Test minimal versions | ||
| id: test-minimal-versions | ||
| working-directory: ${{matrix.workspace-path}} | ||
| run: | | ||
| cargo +${{env.RUST_NIGHTLY_TOOLCHAIN}} minimal-versions check --direct --ignore-private | ||
| cargo +${{env.RUST_NIGHTLY_TOOLCHAIN}} minimal-versions check --direct --ignore-private --all-features | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,8 +36,8 @@ stacktrace = [] | |
| # unstable-foo = [] | ||
|
|
||
| [dependencies] | ||
| aws-lc-rs = { version = "1.6.4" } | ||
| libc = "0.2.121" | ||
|
There was a problem hiding this comment. libc 0.2.121 is needed because aws-lc-sys versions before 0.24.0 required libc 0.2.121. aws-lc-sys 0.24.0 removed the libc dependency, so libc 0.2.62 should be acceptable for aws-lc-sys >= 0.24.0. However, I'm not aware of a way to specify a different minimum version depending on the version of another dependency in a build. We could alternatively specify a higher minimum version for aws-lc-rs, so that aws-lc-sys doesn't specify any libc requirement. |
||
|
|
||
| [build-dependencies] | ||
| cc = { version = "1.0.100", features = ["parallel"] } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,8 +14,8 @@ default = [] | |
| [dependencies] | ||
| s2n-tls = { version = "=0.3.9", path = "../../extended/s2n-tls" } | ||
| s2n-tls-tokio = { version = "=0.3.9", path = "../../extended/s2n-tls-tokio" } | ||
| hyper = { version = "1.4" } | ||
goatgoose marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| hyper-util = { version = "0.1.4", features = ["client-legacy", "tokio", "http1", "http2"] } | ||
|
There was a problem hiding this comment. hyper-util 0.1.4 is needed because we rely on Connection being implemented for TokioIo, which was implemented in 0.1.4. |
||
| tower-service = { version = "0.3" } | ||
| http = { version = "1" } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aws-lc-rs 1.6.4 is needed because the DEP_AWS_LC environment variables were not exported before then, and they're needed in order to build s2n-tls-sys.