ci: update 2 GHAs with merge_queue branch filter #4655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Jul 22, 2024
Comment on lines
-14
to
-16
| merge_group: | ||
| types: [checks_requested] | ||
| branches: [main] |
There was a problem hiding this comment.
Can you expand on why this change is necessary? Why should this run on push instead of merge_group?
There was a problem hiding this comment.
Initially, these checks wouldn't start for #4652, but upon review, they are now triggering as expected. I can't find a github status error explaining why, but this PR does now appear unnecessary.
auto-merge was automatically disabled
July 22, 2024 22:55
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
#4619
Description of changes:
Update two of our actions to start on merge queue pushes, instead of merge_group events.
Based on the branch filter docs.
Call outs
Fixed the yamllint trailing spaces.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.