Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test lax validation of extended key usage #4626

Closed
wants to merge 3 commits into from

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Jun 25, 2024

Description of changes:

Added extension to the tests/pems/permutations/rsae_pkcs_2048_sha256/server-chain.pem

Extension SEQUENCE (3 elem)
    extnID OBJECT IDENTIFIER 2.5.29.37 extKeyUsage (X.509 extension)
    critical BOOLEAN true
    extnValue OCTET STRING (12 byte) 300A06082B06010505070303
        SEQUENCE (1 elem)
            OBJECT IDENTIFIER 1.3.6.1.5.5.7.3.3 codeSigning (PKIX key purpose)

Call-outs:

Address any potentially confusing code. Is there code added that needs to be cleaned up later? Is there code that is missing because it’s still in development?

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@toidiu toidiu changed the title Ak extended key usage test lax validation of extended key usage Jun 25, 2024
@github-actions github-actions bot added the s2n-core team label Jun 25, 2024
@toidiu toidiu closed this Jun 25, 2024
@toidiu toidiu deleted the ak_extendedKeyUsage branch June 25, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant