Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove S2N_NO_PQ option #4622

Merged
merged 3 commits into from
Jun 25, 2024
Merged

fix: remove S2N_NO_PQ option #4622

merged 3 commits into from
Jun 25, 2024

Conversation

kdnakt
Copy link
Contributor

@kdnakt kdnakt commented Jun 22, 2024

Resolved issues:

Resolves #4349

Description of changes:

Removed references to S2N_NO_PQ option and related codes.

Call-outs:

Testing:

I tested with the following commands.

cmake . -Bbuild \
    -DCMAKE_BUILD_TYPE=Release \
    -DCMAKE_PREFIX_PATH=$(dirname $(dirname $(brew list openssl@3|grep libcrypto.dylib))) \
    -DCMAKE_INSTALL_PREFIX=./s2n-tls-install
cmake --build build -j $(sysctl -n hw.ncpu)
CTEST_PARALLEL_LEVEL=$(sysctl -n hw.ncpu) ctest --test-dir build

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kdnakt kdnakt requested a review from dougch as a code owner June 22, 2024 16:01
@lrstewart lrstewart requested review from camshaft and goatgoose June 24, 2024 19:08
Copy link
Contributor

@goatgoose goatgoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for cleaning this up!

@camshaft camshaft enabled auto-merge (squash) June 25, 2024 15:02
@camshaft camshaft merged commit d538d0a into aws:main Jun 25, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove S2N_NO_PQ usage
4 participants