feat(binding): add key update request api #4469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Mar 23, 2024
lrstewart
reviewed
Mar 25, 2024
- return empty tuple for request key update - return non-exhaustive struct for key update count - simplify config builder - gate entire test on ktls feature
- remove conditionally unused import
- another unused import.
lrstewart
approved these changes
Mar 26, 2024
camshaft
approved these changes
Apr 1, 2024
- return &mut Self to stay consistent
lrstewart
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds the bindings for
s2n_connection_get_key_update_countss2n_connection_request_key_updateCall-outs:
s2n_connection_request_key_updateis a part of the unstable ktls feature, so I added anunstable-ktlsfeature for the s2n-tls crate which gates the availability of that function.I'm not love with the plain tuple return of the
key_update_countsmethod. Let me know if people have other thoughts.Testing:
Added a basic unit test checking the expected key updates.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.