-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix libcrypto helpers #4422
Merged
Merged
Nix libcrypto helpers #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
reviewed
Feb 21, 2024
Co-authored-by: James Mayclin <[email protected]>
jmayclin
approved these changes
Mar 1, 2024
lrstewart
approved these changes
Mar 14, 2024
2ce3251
to
3f8ed07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
none
Description of changes:
Some of our tests expect environment variables to alternative libcrypto's to just work, and when entering a devShell interactively- it would be great to remind the user of what's available.
Note that regardless of what libcrypto CMAKE is pointing at, the other binaries should always be there, in this example openssl102 is the CMAKE target and we're still able to execute the 3.0 binary:
Call-outs:
This extends and replaces #4252
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? local
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.