avoid set_waker in s2n-tls-tokio #3889
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Mar 28, 2023
|
|
||
| self.as_mut().set_receive_callback(Some(Self::recv_io_cb))?; | ||
| self.as_mut().set_send_callback(Some(Self::send_io_cb))?; | ||
| self.as_mut().set_receive_context(context)?; | ||
| self.as_mut().set_send_context(context)?; | ||
| self.as_mut().set_waker(Some(ctx.waker()))?; |
There was a problem hiding this comment.
This change won't work with the async callbacks, who all expect there to be a waker set on the connection to work properly. Instead of changing the context, it should be possible to implement a stack Waker that holds a pinned pointer to the async context on the stack.
If this isn't possible, we need to change all of the functions to require &mut core::task::Context be passed into them. And this wouldn't be the worst thing; it would definitely make it more rust-like. It just breaks the signature.
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler than #3748 but has the same performance benefits.