feat(s2n-quic-dc): Add subscriber event for dc::Path creation #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a subscriber with knowledge of the concrete path type to downcast it and register interest for events (e.g., to pull the path secret ID or other relevant metadata as it gets produced).
camshaft
previously approved these changes
Mar 4, 2025
|
Looks like we need to update the metrics snapshots |
Mark-Simulacrum
force-pushed
the
path-created-event
branch
from
199a356 to
4c841f6
Compare
camshaft
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
n/a
Description of changes:
This allows a subscriber with knowledge of the concrete path type to downcast it and register interest for events (e.g., to pull the path secret ID or other relevant metadata as it gets produced).
Call-outs:
This is a new
dyn Anyexposure, but it feels pretty reasonable: we're unlikely to support multiple dc::Paths and regardless registeringdcimpls is unstable so this can change down the line without breaking any realistic use cases.Testing:
No new tests, but I'm not sure it's really warranted for the amount of code contained here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.