feat(s2n-quic): New function added to Connection Limits provider #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Mar 4, 2025
camshaft
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
New API added to allow users to change connection limits based on the information in the TLS handshake, such as server name and application protocol. Previously users could only change connection limits based on their peer's remote address.
Resolved issues:
resolves #1445
Description of changes:
Added a new function to the connection limits provider. Had to feed the limits provider through to the place where we want it to be called
Call-outs:
Not all connection limits should be allowed to be altered, given that some are transport parameters. Therefore I decided to allow only stream batching to be dynamically configured. We can always add more setters on user request.
Testing:
I added a integ test to ensure Connection limits was giving the correct information to the user. Also added a unit test to make sure UpdateableLimits could indeed update the connection limits.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.