Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(s2n-quic-dc): rename stream_id to queue_id #2507

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented Mar 1, 2025

Description of changes:

This change takes the previously unused stream_id field in packets and renames it to queue_id. Long term, this field will be used when multiplexing on a shared UDP socket to map the packet into a locally assigned packet queue. Note that this is currently just a rename and having the endpoint functions take the parameter explicitly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft camshaft force-pushed the camshaft/dc-stream-route-key branch from cfe6a58 to f21fb99 Compare March 4, 2025 18:41
@camshaft camshaft marked this pull request as ready for review March 4, 2025 21:14
@camshaft camshaft requested a review from Mark-Simulacrum March 4, 2025 21:14
@camshaft camshaft force-pushed the camshaft/dc-stream-route-key branch from f21fb99 to 83ac462 Compare March 5, 2025 17:31
@camshaft camshaft changed the title refactor(s2n-quic-dc): rename stream_id to route_key refactor(s2n-quic-dc): rename stream_id to queue_id Mar 5, 2025
@camshaft camshaft enabled auto-merge (squash) March 5, 2025 17:36
@camshaft camshaft merged commit 7d935aa into main Mar 5, 2025
129 checks passed
@camshaft camshaft deleted the camshaft/dc-stream-route-key branch March 5, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants