feat(s2n-quic-dc): accept linger parameter instead of always setting it #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/dc-linger-config
branch
from
215dc72 to
1490c9c
Compare
camshaft
force-pushed
the
camshaft/dc-linger-config
branch
from
1490c9c to
77b8e30
Compare
| @@ -116,7 +120,13 @@ where | |||
| let prev_stream = core::mem::replace(&mut self.stream, Some((stream, remote_address))); | |||
| let prev_ctx = core::mem::replace(&mut self.subscriber_ctx, Some(subscriber_ctx)); | |||
|
|
|||
| if let Some(remote_address) = prev_stream.map(|(_socket, remote_address)| remote_address) { | |||
| if let Some(remote_address) = prev_stream.map(|(socket, remote_address)| { | |||
| if linger.is_none() { | |||
There was a problem hiding this comment.
Suggested change
| if linger.is_none() { | |
| if linger == Some(Duration::ZERO) { |
Maybe? Or we should document what we actually mean by None otherwise I suspect.
There was a problem hiding this comment.
Thinking about it more, it should be
if linger.is_none() || linger != Some(Duration::ZERO) {Basically, we want to hard reset the connection if we drop an old stream for a new one. And the easiest way to do that is setting linger=0. So we only need to set the linger value to 0 if it wasn't already set to that.
camshaft
force-pushed
the
camshaft/dc-linger-config
branch
from
77b8e30 to
bcec5f1
Compare
Mark-Simulacrum
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This changes the TCP APIs to take a
lingerparameter instead of always setting it to0. This avoids issues where the last peer to send data reset streams before transmitting the entire thing - especially where the last chunk is large and can be blocked on things like CWIN and flow control.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.