Access application context from tls connection #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi WeiChao. Are you still planning to work on this? |
|
sure, this is initial implementation, Is it right way fix this issue? |
camshaft
reviewed
Feb 21, 2025
quic/s2n-quic-core/src/crypto/tls.rs
Outdated
| @@ -130,6 +130,8 @@ pub trait Context<Crypto: crate::crypto::CryptoSuite> { | |||
| //# peer's Finished message. | |||
| fn on_handshake_complete(&mut self) -> Result<(), crate::transport::Error>; | |||
|
|
|||
| /// Transfer application context from TLS connection to quic connection | |||
| fn on_application_context(&mut self, _context: Option<Box<dyn Any + Send + Sync>>) {} | |||
There was a problem hiding this comment.
I think we can leave out the default impl here
| @@ -155,6 +156,10 @@ impl tls::Session for Session { | |||
| context.on_tls_exporter_ready(self)?; | |||
| self.handshake_complete = true; | |||
| } | |||
| // TODO Add new s2n-tls new api, take and put in quic::connection | |||
| let ctx: Option<Box<dyn Any + Send + Sync>> = | |||
There was a problem hiding this comment.
Does this need a 'static as well?
There was a problem hiding this comment.
Any already has 'static https://doc.rust-lang.org/std/any/trait.Any.html
|
Does you add |
I won't have time for the next few weeks, unfortunately. If you want to take a stab at it, that would definitely help get this through :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try fix #2437