Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(dc/wireshark): specifiy rust target for bindgen #2414

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented Dec 11, 2024

Description of changes:

Currently we're not pinning rust target versions for the wireshark bindgen commands, which defaults to tracking the latest stable.

This change instead queries the current MSRV for the wireshark crate and pins the rust-target.

Call-outs:

I had to ignore a couple of unused fields with the latest clippy checks.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft camshaft marked this pull request as ready for review December 11, 2024 19:08
@camshaft camshaft merged commit 90f3956 into main Dec 11, 2024
129 of 130 checks passed
@camshaft camshaft deleted the camshaft/dc-wireshark branch December 11, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants