fix(s2n-quic-dc): make TCP shutdown a no-op #2402
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change makes TCP shutdown a no-op. This is done for a few reasons:
Above all, we can avoid more complex shutdown behavior in the TCP layer:
https://datatracker.ietf.org/doc/html/rfc9293#section-3.3.2
Basically, we don't need to go through the 4-way finalization flow but instead jump directly to TIME-WAIT. When combined with linger=0, this can release sockets a lot sooner to the OS which enables busy machines to handle higher TPS (see https://doi.org/10.1109/INFCOM.1999.752180).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.