refactor(s2n-quic-core): move ack::Transmission to core #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/ack-transmission
branch
3 times, most recently
from
c614da7 to
35eb649
Compare
camshaft
force-pushed
the
camshaft/ack-transmission
branch
from
35eb649 to
40ec608
Compare
WesleyRosenblum
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Similar to #2016, this change moves ACK Transmission to s2n-quic-core.
Call-outs:
Since I had to regenerate snapshots, I removed all of them and regenerated all of them. The format has changed a bit (basically with less information to avoid commit churn).
Testing:
All of the tests were moved with the refactor.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.