fix: implement custom PartialEq for connection::Error #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| impl PartialEq for Error { | ||
| #[inline] | ||
| fn eq(&self, other: &Self) -> bool { | ||
| // ignore the `source` attribute when considering if errors are equal |
There was a problem hiding this comment.
what is making the test fail only for rust beta?
There was a problem hiding this comment.
for some reason the beta version started calculating sources differently and we're now getting failures from it. i didn't dig in too much, since it's a good idea to avoid comparing line numbers anyway as part of equivalence.
WesleyRosenblum
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We're currently getting a failure on rustc beta on
main(and a handful of warnings). This PR addresses those issues.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.