fix: address clippy 1.76 (#2114)

.clippy.toml

@@ -1 +1 @@
-msrv = "1.63.0"
+msrv = "1.71.0"

.github/workflows/ci.yml

@@ -804,7 +804,7 @@ jobs:
       - uses: actions-rs/[email protected]
         id: toolchain
         with:
-          toolchain: 1.70.0
+          toolchain: stable
           profile: minimal
           override: true
           components: clippy,rustfmt
@@ -817,11 +817,11 @@ jobs:
 
       - name: Run clippy
         working-directory: tools/xdp
-        run: cargo clippy
+        run: cargo +stable clippy
 
       - name: Build ebpf
         working-directory: tools/xdp
         env:
           RUST_LOG: trace
-        run: cargo xtask ci
+        run: cargo +stable xtask ci
 

.github/workflows/qns.yml

@@ -604,7 +604,7 @@ jobs:
 
       - name: Run cargo build
         working-directory: tools/${{ matrix.attack }}-attack
-        run: cargo build --release
+        run: cargo +stable build --release
 
       - name: Start client
         working-directory: tools/${{ matrix.attack }}-attack

quic/s2n-quic-core/src/packet/number/tests.rs

@@ -105,7 +105,6 @@ fn new(value: VarInt) -> PacketNumber {
 
 /// This implementation tries to closely follow the RFC pseudo code so it's
 /// easier to ensure it matches.
-#[allow(clippy::blocks_in_if_conditions)]
 fn rfc_decoder(largest_pn: u64, truncated_pn: u64, pn_nbits: usize) -> u64 {
     macro_rules! catch {
         ($expr:expr) => {

quic/s2n-quic-transport/src/connection/connection_container.rs

@@ -842,11 +842,13 @@ impl<C: connection::Trait, L: connection::Lock<C>> ConnectionContainer<C, L> {
         let cursor = self.connection_map.find(&connection_id);
         let node = cursor.get()?;
 
-        let (result, interests) = match node.inner.write(|conn| {
+        let on_write = |conn: &mut C| {
             let result = func(conn);
             let interests = conn.interests();
             (result, interests)
-        }) {
+        };
+
+        let (result, interests) = match node.inner.write(on_write) {
             Ok(result) => result,
             Err(_) => {
                 // the connection panicked so remove it from the container
@@ -992,7 +994,7 @@ impl<C: connection::Trait, L: connection::Lock<C>> ConnectionContainer<C, L> {
             // also clear the timer to make the state consistent
             connection.timeout.set(None);
 
-            let mut interests = match connection.inner.write(|conn| {
+            let on_write = |conn: &mut C| {
                 let remote_address = conn
                     .remote_address()
                     .expect("Remote address should be available");
@@ -1004,7 +1006,9 @@ impl<C: connection::Trait, L: connection::Lock<C>> ConnectionContainer<C, L> {
                 );
                 func(conn, &context);
                 conn.interests()
-            }) {
+            };
+
+            let mut interests = match connection.inner.write(on_write) {
                 Ok(result) => result,
                 Err(_) => {
                     self.remove_poisoned_node(&connection);