Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #783

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Fix build #783

merged 6 commits into from
Feb 7, 2025

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Feb 7, 2025

Description

It seems like NPM or Corepack messed something up in the backend that caused Corepack to break when checking signatures. So the issue is fixed by installing the latest version of Corepack.

I also updated Node and NVM while I was trying different things and decided to keep the changes as they are low risk. I also added a new GitHub Action that will run on PRs and just build the docker image. This ensures it won't fail because of a PR.

Validation

  • Ran build locally
  • Tested in GitHub Action

Related Issues

  • None

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.96%. Comparing base (9d3a2b7) to head (f2f097a).
Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
+ Coverage   14.88%   20.96%   +6.07%     
==========================================
  Files         566      523      -43     
  Lines       25121    22442    -2679     
  Branches     1170     1200      +30     
==========================================
+ Hits         3739     4704     +965     
+ Misses      21050    17494    -3556     
+ Partials      332      244      -88     
Flag Coverage Δ
unittests 20.96% <ø> (+6.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmcginnes kmcginnes marked this pull request as ready for review February 7, 2025 04:25
@andreachild
Copy link

LGTM

@kmcginnes kmcginnes merged commit 46372f5 into aws:main Feb 7, 2025
2 checks passed
@kmcginnes kmcginnes deleted the fix-build branch February 7, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants