Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak styles in multiple components #780

Merged
merged 14 commits into from
Feb 6, 2025
Merged

Conversation

kmcginnes
Copy link
Collaborator

@kmcginnes kmcginnes commented Feb 5, 2025

Description

  • Update icons in graph toolbar to use Lucide Icons
  • Tweak Toast styles with rounder corners and more padding
  • Add loading type to toast notifications with spinner
  • Remove redundant spin animation since tailwindcss-animate includes one
  • Add simple Spinner component
  • Tweak IconButton style to show background when popover is open, reduce icon size in default size variant
  • Tweak PanelHeaderActionButton to forward ref (allows popover to work) and allow the component to not have a click handler
  • Tweak PanelHeaderActions to increase gap between items
  • Tweak PanelHeaderDivider to ad a bit more space around the divider
  • Tweak ImportantBlock to increase padding and rounder corners
  • Fix alignment of "Node label" and "Attribute" fields in search sidebar
  • Add react-hook-form, which we will slowly migrate to for any form that has a submit action (first use will be export, then connection creation or editing)
    • Add form components that integrate with react-hook-form and zod for validation

Validation

Before After
CleanShot 2025-02-05 at 11 51 46@2x CleanShot 2025-02-05 at 11 49 01@2x
CleanShot 2025-02-05 at 11 51 23@2x CleanShot 2025-02-05 at 11 49 23@2x
CleanShot 2025-02-05 at 11 51 47@2x CleanShot 2025-02-05 at 11 49 04@2x
CleanShot 2025-02-05 at 11 51 17@2x CleanShot 2025-02-05 at 11 50 38@2x
CleanShot 2025-02-05 at 11 52 01@2x CleanShot 2025-02-06 at 10 51 55@2x

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@kmcginnes kmcginnes marked this pull request as ready for review February 5, 2025 18:08
@kmcginnes kmcginnes marked this pull request as draft February 6, 2025 16:53
@kmcginnes kmcginnes marked this pull request as ready for review February 6, 2025 16:58
Cole-Greer
Cole-Greer previously approved these changes Feb 6, 2025
Copy link

@Cole-Greer Cole-Greer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of those tweaked components look a lot better to me.

@kmcginnes kmcginnes merged commit ec7d6f5 into aws:main Feb 6, 2025
1 check passed
@kmcginnes kmcginnes deleted the tweak-styles branch February 6, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants