Signature of capturePostgres is mismatched with the implementation
#504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It must be equivalent to require import:
```js
var capturePostgres = require('aws-xray-sdk-postgres');
```
I get this error when try to follow the type definition of this package with TypeScript
```ts
import { capturePostgres } from "aws-xray-sdk-postgres";
```
Then I get this error:
```sh
TypeError: (0 , external_aws_xray_sdk_postgres_namespaceObject.capturePostgres) is not a function
```
hckhanh
changed the title
capturePostgres is mismatched with the implementation
|
Hi @hckhanh it seems this change is causing linting issues could you address those? |
|
Hi @willarmiros, the linting error is |
|
Or I simply change the lint rule to make it successed. |
We can't make any backwards incompatible/breaking changes. I would recommend ignoring the lint rule in code and adding a comment explaining why we suppress it. |
|
Any chance we could get this over the line so that we can close #450? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It must be equivalent to:
I get this error when try to follow the type definition of this package with TypeScript
Then I get this error:
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.