test(amazonq): reset state after each testgen e2e test #6522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/runIntegrationTests |
|
/runintegrationTests |
|
/runIntegrationTests |
|
/runintegrationTests |
1 similar comment
|
/runintegrationTests |
|
/runIntegrationTests |
|
/runIntegrationTests |
|
/runIntegrationTests |
chungjac
changed the title
|
/runIntegrationTests |
nkomonen-amazon
approved these changes
Feb 17, 2025
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem 1. The /test command can occasionally create test files in directories unrelated to the source file location (this is a known science issue that will be addressed) 2. Unit tests generated after the "Clicks on accept" test may possibly accumulate in the CI since testFixtures isn't reset for each build. This can lead to bloated test environments as these tests should be isolated and start with a clean state. ## Solution 1. Add a dedicated testgen folder within testFixtures to isolate from other files. This prevents cross-contamination (ex: python tests appearing in java directories) 2. Clean up generated unit tests after "Clicks on accept" test --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.