Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amazonq): Fix LSP start failure in al2023 arm64 #6476

Closed
wants to merge 1 commit into from
Closed

fix(amazonq): Fix LSP start failure in al2023 arm64 #6476

wants to merge 1 commit into from
+5 −1

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented Jan 31, 2025

Problem

The LSP cannot start in AL2023 arm64.

Solution

Update the binary of linux arm64 to make it compatible with both AL2023 and Ubuntu arm64

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners January 31, 2025 18:03
@github-actions GitHub Actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@leigaol leigaol requested a review from Will-ShaoHua January 31, 2025 18:04
@jpinkney-aws
Copy link
Contributor

It looks like your branch name is invalid because it starts with a number, causing the lint-commits job to fail

@leigaol leigaol closed this Feb 3, 2025
@leigaol
Copy link
Contributor Author

leigaol commented Feb 3, 2025

It looks like your branch name is invalid because it starts with a number, causing the lint-commits job to fail

Moved to #6488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewyuq andrewyuq andrewyuq approved these changes

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

@jpinkney-aws jpinkney-aws jpinkney-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leigaol @jpinkney-aws @andrewyuq @Will-ShaoHua