feat(amazonq): migrate /doc and /dev to zipStream #6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/runIntegrationTests |
avi-alpert
force-pushed
the
aalpert/zip-stream
branch
from
a2136c9 to
d0194dd
Compare
|
The duplicate code CI finding is on lines untouched by this PR (previously written unit tests) |
avi-alpert
commented
Jan 31, 2025
chengoramazon
approved these changes
Jan 31, 2025
michaellandi
approved these changes
Jan 31, 2025
justinmk3
reviewed
Feb 12, 2025
| @@ -48,6 +48,7 @@ export * from './localizedText' | |||
| export * as env from './vscode/env' | |||
| export * from './vscode/commands2' | |||
| export * from './utilities/pathUtils' | |||
| export * from './utilities/zipStream' | |||
There was a problem hiding this comment.
should be exported as * as zipStream
justinmk3
reviewed
Feb 12, 2025
| @@ -150,4 +154,13 @@ export class ZipStream { | |||
| streamBuffer: this._streamBuffer, | |||
| } | |||
| } | |||
|
|
|||
| public static async unzip(zipBuffer: Buffer): Promise<ZipReaderResult[]> { | |||
There was a problem hiding this comment.
This isn't a streaming interface. So consumers of this function will be limited by available memory.
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
## Problem Users see a `Sorry, I ran into an issue while trying to upload your code` error when using /dev or /doc if files in the repo have a modified or created time before the MSDOS epoch. This affects some users who Remote SSH into a Linux machine. Logs show an out of range exception thrown from the adm-zip package. Adm-zip issue reported [here](cthackers/adm-zip#485) ## Solution Switch to the internal [zipStream module](https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/shared/utilities/zipStream.ts) --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users see a
Sorry, I ran into an issue while trying to upload your codeerror when using /dev or /doc if files in the repo have a modified or created time before the MSDOS epoch. This affects some users who Remote SSH into a Linux machine.Logs show an out of range exception thrown from the adm-zip package. Adm-zip issue reported here
Solution
Switch to the internal zipStream module
feature/xbranches will not be squash-merged at release time.