-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(childprocess): add new interfaces for tracking child processes #6394
Open
Hweinstock
wants to merge
56
commits into
aws:master
Choose a base branch
from
Hweinstock:process/command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Jan 17, 2025
@@ -0,0 +1,4 @@ | |||
{ | |||
"type": "Feature", | |||
"description": "Subprocesses are now tracked and visible by \"Log All Active Subprocesses\" in command palette" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we introduce it as a more generic Show Stats
or Report Performance
command? Even if it only has process stuff currently.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Subprocesses are now tracked, by #6304, but this isn't visible to the user. Additionally, while the subprocesses are tracked in the logs, they aren't tracked in telemetry.
Solution
New Metrics
Upon investigation, it doesn't look like https://github.com/aws/aws-toolkit-common contains any metrics we can use.
ide_showExtStats
:aws-toolkit-vscode/packages/core/src/shared/telemetry/vscodeTelemetry.json
Lines 391 to 400 in b329ede
ide_childProcessWarning
:aws-toolkit-vscode/packages/core/src/shared/telemetry/vscodeTelemetry.json
Lines 401 to 414 in b329ede
Porting to commons: aws/aws-toolkit-common#962
Alternative Solution
Pictures
feature/x
branches will not be squash-merged at release time.