Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(childprocess): add new interfaces for tracking child processes #6394

Open
wants to merge 56 commits into
base: master
Choose a base branch
from

Conversation

Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Jan 17, 2025

Problem

Subprocesses are now tracked, by #6304, but this isn't visible to the user. Additionally, while the subprocesses are tracked in the logs, they aren't tracked in telemetry.

Solution

  • add a command to spit this information out into the logs to make it visible to user.
  • add telemetry to make this information visible to the dev team.

New Metrics

Upon investigation, it doesn't look like https://github.com/aws/aws-toolkit-common contains any metrics we can use.

ide_showExtStats :

{
"name": "ide_showExtStats",
"description": "Emitted when user invokes show extensions stats command",
"metadata": [
{
"type": "numChildProcesses",
"required": true
}
]
},

ide_childProcessWarning :
{
"name": "ide_childProcessWarning",
"description": "Child Process warning due to high system usage",
"metadata": [
{
"type": "systemResource",
"required": true
},
{
"type": "childProcess",
"required": true
}
]
},

Porting to commons: aws/aws-toolkit-common#962

Alternative Solution

  • Display a proper table in a virtual document that we open (similar to cwl).

Pictures

image
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -0,0 +1,4 @@
{
"type": "Feature",
"description": "Subprocesses are now tracked and visible by \"Log All Active Subprocesses\" in command palette"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we introduce it as a more generic Show Stats or Report Performance command? Even if it only has process stuff currently.

Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants