-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(amazonq): Add e2e tests for general amazon q chat panel #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinkney-aws
changed the title
tests(amazonq): Add e2e tests for general amazon q chat panel
test(amazonq): Add e2e tests for general amazon q chat panel
Dec 20, 2024
/runIntegrationTests |
nkomonen-amazon
approved these changes
Jan 14, 2025
justinmk3
reviewed
Jan 14, 2025
justinmk3
approved these changes
Jan 14, 2025
jpinkney-aws
force-pushed
the
tests
branch
2 times, most recently
from
January 15, 2025 14:03
f0c72a5
to
882ee14
Compare
/runIntegrationTests |
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
## Problem - We want tests for the general amazon q panel - We want other teams to quickly be able to write tests for their agents ## Solution - Add general tests for the amazon q chat panel - Add a template that other teams can use to write their tests - Fix an issue that occurred only in tests where tab id's weren't defined for the help message. The problem was that in the framework everything is instant which meant a tab id was defined before that code ran and was never passed through to processQuickActionCommand - By default don't show the welcome page for now tests --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/x
branches will not be squash-merged at release time.