Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(amazonq): Add e2e tests for general amazon q chat panel #6279

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

jpinkney-aws
Copy link
Contributor

Problem

  • We want tests for the general amazon q panel
  • We want other teams to quickly be able to write tests for their agents

Solution

  • Add general tests for the amazon q chat panel
  • Add a template that other teams can use to write their tests
  • Fix an issue that occurred only in tests where tab id's weren't defined for the help message. The problem was that in the framework everything is instant which meant a tab id was defined before that code ran and was never passed through to processQuickActionCommand
  • By default don't show the welcome page for now tests

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested review from a team as code owners December 20, 2024 13:16
@jpinkney-aws jpinkney-aws changed the title tests(amazonq): Add e2e tests for general amazon q chat panel test(amazonq): Add e2e tests for general amazon q chat panel Dec 20, 2024
@jpinkney-aws jpinkney-aws reopened this Dec 20, 2024
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws jpinkney-aws force-pushed the tests branch 2 times, most recently from f0c72a5 to 882ee14 Compare January 15, 2025 14:03
@jpinkney-aws
Copy link
Contributor Author

/runIntegrationTests

@jpinkney-aws jpinkney-aws merged commit 2e424b3 into aws:master Jan 15, 2025
26 checks passed
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
## Problem
- We want tests for the general amazon q panel
- We want other teams to quickly be able to write tests for their agents

## Solution
- Add general tests for the amazon q chat panel
- Add a template that other teams can use to write their tests
- Fix an issue that occurred only in tests where tab id's weren't
defined for the help message. The problem was that in the framework
everything is instant which meant a tab id was defined before that code
ran and was never passed through to processQuickActionCommand
- By default don't show the welcome page for now tests

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants