Skip to content

Commit

Permalink
build: set module=node16 in tsconfig.json #4546
Browse files Browse the repository at this point in the history
Problem:
vscode shows warning:

    TS5110: Option 'module' must be set to 'Node16' when option
    'moduleResolution' is set to 'Node16'

Solution:
- Set `module=node16`.
- Update all tsconfig.json files to use the same "moduleResolution" and
  "module" settings.

Reference:
- https://www.typescriptlang.org/tsconfig#moduleResolution
  • Loading branch information
justinmk3 authored Mar 16, 2024
1 parent 63cf28b commit bdccdaa
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion packages/tsconfig.packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@sinonjs/fake-timers": ["node_modules/@types/sinonjs__fake-timers"]
},
"incremental": true,
"module": "commonjs",
"module": "node16",
"target": "es2021",
"sourceMap": true,
"moduleResolution": "node16",
Expand Down
4 changes: 2 additions & 2 deletions plugins/eslint-plugin-aws-toolkits/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
"compilerOptions": {
"baseUrl": ".",
"incremental": true,
"module": "commonjs",
"module": "node16",
"target": "es2021",
"outDir": "dist",
"lib": ["dom", "es2021"],
"sourceMap": true,
"moduleResolution": "node",
"moduleResolution": "node16",
"resolveJsonModule": true,
"strict": true,
"noUnusedLocals": true,
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
// If you are looking for the base config for subprojects, see packages/tsconfig.packages.json
{
"compilerOptions": {
"module": "commonjs",
"module": "node16",
"target": "es2021",
"moduleResolution": "node",
"moduleResolution": "node16",
"rootDir": ".",
"resolveJsonModule": true,
"strict": true,
Expand Down

0 comments on commit bdccdaa

Please sign in to comment.