Skip to content

Commit

Permalink
update to require problem matcher extension (#4729)
Browse files Browse the repository at this point in the history
When we build locally this problem matcher helps the IDE detect that
a webpack watch execution is finished so that the build scripts
can progress.

Signed-off-by: Nikolas Komonen <[email protected]>
  • Loading branch information
nkomonen-amazon authored Apr 17, 2024
1 parent 21b96fa commit b2969ff
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 16 deletions.
3 changes: 3 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"recommendations": ["amodio.tsl-problem-matcher", "dbaeumer.vscode-eslint"]
}
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ To develop this project, install these dependencies:
- [Git](https://git-scm.com/downloads)
- (optional) Set `git blame` to ignore noise-commits: `git config blame.ignoreRevsFile .git-blame-ignore-revs`
- [AWS `git secrets`](https://github.com/awslabs/git-secrets)
- (required for Web mode) [TypeScript + Webpack Problem Matcher](https://marketplace.visualstudio.com/items?itemName=amodio.tsl-problem-matcher)
- [TypeScript + Webpack Problem Matcher](https://marketplace.visualstudio.com/items?itemName=amodio.tsl-problem-matcher)
- Not installing will result in the following error during building: `Error: Invalid problemMatcher reference: $ts-webpack-watch`
- (optional) [AWS SAM CLI](https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-install.html)
- (optional) [Docker](https://docs.docker.com/get-docker/)

Expand Down
5 changes: 0 additions & 5 deletions packages/amazonq/.vscode/extensions.json

This file was deleted.

5 changes: 0 additions & 5 deletions packages/core/.vscode/extensions.json

This file was deleted.

5 changes: 0 additions & 5 deletions packages/toolkit/.vscode/extensions.json

This file was deleted.

0 comments on commit b2969ff

Please sign in to comment.