Use importlib instead of pkg_resources #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirkafajfr
previously approved these changes
May 6, 2024
willtong1234
approved these changes
May 13, 2024
jirkafajfr
approved these changes
May 13, 2024
|
@simonmarty Thanks for this fix! I see you've also added |
|
When will this PR be added to the public facing library (assuming it is going to be v1.1.3)? |
|
@simonmarty We need this released, as the latest release on PyPI is broken. |
|
v1.1.3 is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Closes #42
Description of changes:
pkg_resourcesis deprecated, useimportlib.metadatainsteadTesting
Ran
toxsuite.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.