Skip to content

chore: add Prettier action, update/cleanup workflows, format files #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ThirdEyeSqueegee
Copy link
Member

@ThirdEyeSqueegee ThirdEyeSqueegee commented Apr 30, 2025

Issue #, if available:
N/A

Description of changes:

  • Add Prettier action for .md and .yml files
  • Add Prettier instructions to CONTRIBUTING.md
  • Bump workflow versions
  • Add pull_request trigger for rust.yml
  • Remove push trigger for rust.yml
  • Format files
  • Add rutajdash/prettier-cli-action to actions allowlist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ThirdEyeSqueegee ThirdEyeSqueegee requested a review from a team as a code owner April 30, 2025 18:52
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 41.82%. Comparing base (bc50c3e) to head (f653066).

Files with missing lines Patch % Lines
aws_secretsmanager_agent/src/config.rs 20.00% 8 Missing ⚠️
aws_secretsmanager_agent/src/server.rs 0.00% 8 Missing ⚠️
aws_secretsmanager_caching/src/output.rs 0.00% 4 Missing ⚠️
aws_secretsmanager_caching/src/lib.rs 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   42.19%   41.82%   -0.38%     
==========================================
  Files          14       14              
  Lines        8986     8570     -416     
==========================================
- Hits         3792     3584     -208     
+ Misses       5194     4986     -208     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@simonmarty simonmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs IDE-independent instructions to run the formatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants