Support IMDS V2.1 #3255
Open
Support IMDS V2.1 #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mullermp
reviewed
Jun 8, 2025
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
Roy-Gal-Git
reviewed
Jun 10, 2025
jterapin
commented
Jun 11, 2025
gems/aws-sdk-core/lib/aws-sdk-core/credential_provider_chain.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
jterapin
commented
Jun 14, 2025
gems/aws-sdk-core/lib/aws-sdk-core/credential_provider_chain.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
mullermp
approved these changes
Jun 18, 2025
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/spec/aws/instance_profile_credentials_spec.rb
Outdated
Show resolved
Hide resolved
gems/aws-sdk-core/spec/aws/instance_profile_credentials_spec.rb
Outdated
Show resolved
Hide resolved
| { status: 200, body: ' ' }, | ||
| { status: 200, body: '' }, | ||
| { status: 200, body: '{' }, | ||
| { status: 200, body: resp.to_json } |
There was a problem hiding this comment.
We should check if we want 3 retries or 3 attempts.
mullermp
reviewed
Jun 18, 2025
|
Detected 2 possible performance regressions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds support for IMDS V2.1 - which includes sourcing of account id with credentials. If the underlying EC2 instance's IMDS supports it - the provider can retrieve credentials that include an account ID. Then, this account ID can be used by account-based endpoints.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
To make sure we include your contribution in the release notes, please make sure to add description entry for your changes in the "unreleased changes" section of the
CHANGELOG.mdfile (at corresponding gem). For the description entry, please make sure it lives in one line and starts withFeatureorIssuein the correct format.For generated code changes, please checkout below instructions first:
https://github.com/aws/aws-sdk-ruby/blob/version-3/CONTRIBUTING.md
Thank you for your contribution!